Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IR] Add m_c_BitwiseLogic in pattern match; NFC #86632

Closed
wants to merge 1 commit into from
Closed

[IR] Add m_c_BitwiseLogic in pattern match; NFC #86632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions llvm/include/llvm/IR/PatternMatch.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1357,7 +1357,8 @@ m_NUWAddLike(const LHS &L, const RHS &R) {
//===----------------------------------------------------------------------===//
// Class that matches a group of binary opcodes.
//
template <typename LHS_t, typename RHS_t, typename Predicate>
template <typename LHS_t, typename RHS_t, typename Predicate,
bool Commutable = false>
struct BinOpPred_match : Predicate {
LHS_t L;
RHS_t R;
Expand All @@ -1366,8 +1367,10 @@ struct BinOpPred_match : Predicate {

template <typename OpTy> bool match(OpTy *V) {
if (auto *I = dyn_cast<Instruction>(V))
return this->isOpType(I->getOpcode()) && L.match(I->getOperand(0)) &&
R.match(I->getOperand(1));
return this->isOpType(I->getOpcode()) &&
((L.match(I->getOperand(0)) && R.match(I->getOperand(1))) ||
(Commutable && L.match(I->getOperand(1)) &&
R.match(I->getOperand(0))));
return false;
}
};
Expand Down Expand Up @@ -1434,6 +1437,13 @@ m_BitwiseLogic(const LHS &L, const RHS &R) {
return BinOpPred_match<LHS, RHS, is_bitwiselogic_op>(L, R);
}

/// Matches bitwise logic operations in either order.
template <typename LHS, typename RHS>
inline BinOpPred_match<LHS, RHS, is_bitwiselogic_op, true>
m_c_BitwiseLogic(const LHS &L, const RHS &R) {
return BinOpPred_match<LHS, RHS, is_bitwiselogic_op, true>(L, R);
}

/// Matches integer division operations.
template <typename LHS, typename RHS>
inline BinOpPred_match<LHS, RHS, is_idiv_op> m_IDiv(const LHS &L,
Expand Down
39 changes: 39 additions & 0 deletions llvm/unittests/IR/PatternMatch.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,6 +494,45 @@ TEST_F(PatternMatchTest, Unless) {
EXPECT_FALSE(m_Unless(m_c_Add(m_Zero(), m_One())).match(X));
}

TEST_F(PatternMatchTest, BitWise) {
Value *Or = IRB.CreateOr(IRB.getInt32(1), IRB.getInt32(0));
Value *Xor = IRB.CreateXor(IRB.getInt32(1), IRB.getInt32(0));
Value *And = IRB.CreateXor(IRB.getInt32(1), IRB.getInt32(0));
Constant *T = IRB.getInt1(true);
Constant *F = IRB.getInt1(false);
Value *Alloca = IRB.CreateAlloca(IRB.getInt1Ty());
Value *X = IRB.CreateLoad(IRB.getInt1Ty(), Alloca);
Value *Y = IRB.CreateLoad(IRB.getInt1Ty(), Alloca);
Value *LAnd = IRB.CreateSelect(X, Y, F);
Value *LOr = IRB.CreateSelect(X, T, Y);
Value *Add = IRB.CreateAdd(IRB.getInt32(1), IRB.getInt32(0));

EXPECT_TRUE(m_BitwiseLogic(m_One(), m_Zero()).match(Or));
EXPECT_TRUE(m_BitwiseLogic(m_One(), m_Zero()).match(Xor));
EXPECT_TRUE(m_BitwiseLogic(m_One(), m_Zero()).match(And));
EXPECT_FALSE(m_BitwiseLogic(m_Value(), m_Value()).match(LAnd));
EXPECT_FALSE(m_BitwiseLogic(m_Value(), m_Value()).match(LOr));
EXPECT_FALSE(m_BitwiseLogic(m_Value(), m_Value()).match(Add));

EXPECT_FALSE(m_BitwiseLogic(m_Zero(), m_One()).match(Or));
EXPECT_FALSE(m_BitwiseLogic(m_Zero(), m_One()).match(Xor));
EXPECT_FALSE(m_BitwiseLogic(m_Zero(), m_One()).match(And));

EXPECT_TRUE(m_c_BitwiseLogic(m_One(), m_Zero()).match(Or));
EXPECT_TRUE(m_c_BitwiseLogic(m_One(), m_Zero()).match(Xor));
EXPECT_TRUE(m_c_BitwiseLogic(m_One(), m_Zero()).match(And));
EXPECT_FALSE(m_c_BitwiseLogic(m_Value(), m_Value()).match(LAnd));
EXPECT_FALSE(m_c_BitwiseLogic(m_Value(), m_Value()).match(LOr));
EXPECT_FALSE(m_c_BitwiseLogic(m_Value(), m_Value()).match(Add));

EXPECT_TRUE(m_c_BitwiseLogic(m_Zero(), m_One()).match(Or));
EXPECT_TRUE(m_c_BitwiseLogic(m_Zero(), m_One()).match(Xor));
EXPECT_TRUE(m_c_BitwiseLogic(m_Zero(), m_One()).match(And));

EXPECT_FALSE(m_c_BitwiseLogic(m_One(), m_One()).match(Or));
EXPECT_FALSE(m_c_BitwiseLogic(m_Zero(), m_Zero()).match(Xor));
}

TEST_F(PatternMatchTest, ZExtSExtSelf) {
LLVMContext &Ctx = IRB.getContext();

Expand Down
Loading