[flang] Fix crash in semantics on bad program #87199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't accept a putative statement function definition for a symbol that is a subprogram but can't possibly be a statement function. Fixes llvm#86936.
llvmbot
added
flang
Member
|
@llvm/pr-subscribers-flang-semantics Author: Peter Klausler (klausler) ChangesDon't accept a putative statement function definition for a symbol that is a subprogram but can't possibly be a statement function. Fixes #86936. Full diff: https://github.com/llvm/llvm-project/pull/87199.diff 1 Files Affected:
diff --git a/flang/lib/Semantics/resolve-names.cpp b/flang/lib/Semantics/resolve-names.cpp
index 2e88a2daff2c08..f2db329e30be78 100644
--- a/flang/lib/Semantics/resolve-names.cpp
+++ b/flang/lib/Semantics/resolve-names.cpp
@@ -8525,7 +8525,9 @@ void ResolveNamesVisitor::AnalyzeStmtFunctionStmt(
Symbol *symbol{name.symbol};
auto *details{symbol ? symbol->detailsIf<SubprogramDetails>() : nullptr};
if (!details || !symbol->scope() ||
- &symbol->scope()->parent() != &currScope()) {
+ &symbol->scope()->parent() != &currScope() || details->isInterface() ||
+ details->isDummy() || details->entryScope() ||
+ details->moduleInterface() || symbol->test(Symbol::Flag::Subroutine)) {
return; // error recovery
}
// Resolve the symbols on the RHS of the statement function.
|
jeanPerier
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't accept a putative statement function definition for a symbol that is a subprogram but can't possibly be a statement function.
Fixes #86936.