[TableGen][InstrInfoEmitter] Count sub-operands on def operands #88972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4
Created using spr 1.3.4
arsenm
approved these changes
Apr 16, 2024
arsenm
reviewed
Apr 16, 2024
Comment on lines
+1185
to
+1189
| int DefOperands = 0; | ||
| if (Inst.Operands.NumDefs) { | ||
| auto &Opnd = Inst.Operands[Inst.Operands.NumDefs - 1]; | ||
| DefOperands = Opnd.MIOperandNo + Opnd.MINumOperands; | ||
| } |
There was a problem hiding this comment.
We probably should have some better helpers for dealing with these compound operands
darkbuck
added a commit
that referenced
this pull request
Apr 17, 2024
- If a def operand includes multiple sub-operands, count them when generating instr info. - Found issues in x86 and sparc backends, where memory operands of store or store-like instructions are wrongly placed in the output list. Reviewers: jayfoad, arsenm, Pierre-vh Reviewed By: arsenm Pull Request: #88972
darkbuck
deleted the
users/darkbuck/spr/tablegeninstrinfoemitter-count-sub-operands-on-def-operands-1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generating instr info.
store or store-like instructions are wrongly placed in the output
list.