-
Notifications
You must be signed in to change notification settings - Fork 15.5k
[LAA] Always use DepCands when grouping runtime checks. #91196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fhahn
wants to merge
18
commits into
llvm:main
Choose a base branch
from
fhahn:laa-unknown-dep-rt-checks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
1059eb7
[LAA] Always use DepCands when grouping runtime checks.
fhahn 54ebebf
Merge branch 'main' into laa-unknown-dep-rt-checks
fhahn fc9cee7
Merge remote-tracking branch 'origin/main' into laa-unknown-dep-rt-ch…
fhahn 2943e88
!fixup update new tests.
fhahn 98e7a47
Merge remote-tracking branch 'origin/main' into laa-unknown-dep-rt-ch…
fhahn 1059148
Merge remote-tracking branch 'origin/main' into laa-unknown-dep-rt-ch…
fhahn 029a21d
Merge remote-tracking branch 'origin/main' into laa-unknown-dep-rt-ch…
fhahn 6612413
Merge remote-tracking branch 'origin/main' into laa-unknown-dep-rt-ch…
fhahn 9189e84
Merge remote-tracking branch 'origin/main' into laa-unknown-dep-rt-ch…
fhahn a12665a
Update after merge.
fhahn 1772f07
Merge remote-tracking branch 'origin/main' into laa-unknown-dep-rt-ch…
fhahn 9329501
!fixup update after udpating to main.
fhahn 6458ad6
Merge remote-tracking branch 'origin/main' into laa-unknown-dep-rt-ch…
fhahn b9673a5
!fixup clear DepCands if getDependences fails.
fhahn 46e99a2
Merge remote-tracking branch 'origin/main' into laa-unknown-dep-rt-ch…
fhahn 7b6d6b9
!fixup clear dependencies after no longer needed
fhahn e78769c
Merge remote-tracking branch 'origin/main' into laa-unknown-dep-rt-ch…
fhahn 73825ac
!fixup address comments, thanks
fhahn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I correct that when both pointers have the same underlying object, only one of the eraseClass calls actually does anything (the second is a no-op)? This seems harmless; just confirming my understanding.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, if we already earased the class then this will be a no-op
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a comment here - or removing this line and adding a comment instead - would be helpful for future readers