Skip to content

[libunwind] Remove needless sys/uio.h #97495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

izaakschroeder
Copy link
Contributor

@izaakschroeder izaakschroeder commented Jul 3, 2024

No reference to readv or writev. This makes libcxx happy when compiling against clang's libc as part of #97191.

No reference to `readv` or `writev`.
@izaakschroeder izaakschroeder requested a review from a team as a code owner July 3, 2024 00:27
@llvmbot
Copy link
Member

llvmbot commented Jul 3, 2024

@llvm/pr-subscribers-libunwind

Author: Izaak Schroeder (izaakschroeder)

Changes

No reference to readv or writev.


Full diff: https://github.com/llvm/llvm-project/pull/97495.diff

1 Files Affected:

  • (modified) libunwind/src/UnwindCursor.hpp (-1)
diff --git a/libunwind/src/UnwindCursor.hpp b/libunwind/src/UnwindCursor.hpp
index 66fe8e2a32cca..677e842d8a22b 100644
--- a/libunwind/src/UnwindCursor.hpp
+++ b/libunwind/src/UnwindCursor.hpp
@@ -36,7 +36,6 @@
 #include <errno.h>
 #include <signal.h>
 #include <sys/syscall.h>
-#include <sys/uio.h>
 #include <unistd.h>
 #define _LIBUNWIND_CHECK_LINUX_SIGRETURN 1
 #endif

@izaakschroeder
Copy link
Contributor Author

/cc @michaelrj-google @jhuber6

@izaakschroeder izaakschroeder mentioned this pull request Jul 3, 2024
39 tasks
Copy link
Member

@ldionne ldionne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is happy.

@jhuber6 jhuber6 merged commit 495452e into llvm:main Jul 3, 2024
54 of 56 checks passed
lravenclaw pushed a commit to lravenclaw/llvm-project that referenced this pull request Jul 3, 2024
No reference to `readv` or `writev`. This makes `libcxx` happy when
compiling against clang's `libc` as part of
llvm#97191.
@izaakschroeder izaakschroeder deleted the libunwind-remove-uio branch July 3, 2024 18:38
kbluck pushed a commit to kbluck/llvm-project that referenced this pull request Jul 6, 2024
No reference to `readv` or `writev`. This makes `libcxx` happy when
compiling against clang's `libc` as part of
llvm#97191.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants