Fix MicroBenchmark build on Linux with clang 18.1.8 #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jroelofs
approved these changes
Jul 22, 2024
MicroBenchmarks/libs/benchmark/test/options_test.cc fails to build on Linux/AArch64 with following error: error: variable 'actual_iterations' set but not used This patch adds benchmark::DoNotOptimize(actual_iterations); to to function BM_explicit_iteration_count in options_test.cc -Wall and -Werror were being used to compile and I am surprised that this was not caught by any of the buildbots. Some versions of clang compile this all fine with -Wall -Werror.
omjavaid
force-pushed
the
fix_options_test
branch
from
7bfeb24
to
720d0c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MicroBenchmarks/libs/benchmark/test/options_test.cc fails to build on Linux/AArch64 with following error:
error: variable 'actual_iterations' set but not used
This patch adds benchmark::DoNotOptimize(actual_iterations); to to function BM_explicit_iteration_count in options_test.cc
-Wall and -Werror were being used to compile and I am surprised that this was not caught by any of the buildbots.
Some versions of clang compile this all fine with -Wall -Werror.