Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMDGPU][Flang] Adds MLIR as dependency #304

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

jplehr
Copy link
Contributor

@jplehr jplehr commented Nov 11, 2024

Since flang depends on MLIR, depend on MLIR for changes to catch problems early.

Copy link

@mjklemm mjklemm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nit: maybe put the dependency in order (so, mlir goes before flang)?

Since flang depends on MLIR, depend on MLIR for changes to catch
problems early.
@jplehr jplehr force-pushed the feat/flang-deps-on-mlir branch from ae2b946 to c0402df Compare November 11, 2024 11:27
@jplehr jplehr requested a review from mjklemm November 11, 2024 11:27
Copy link

@mjklemm mjklemm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jplehr jplehr merged commit 714a5f1 into llvm:main Nov 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants