Skip to content

Conversation

@hekota
Copy link
Member

@hekota hekota commented Nov 19, 2025

This change addresses new warnings introduced in Clang 21.1.

  • Updates a function to be static instead of being in anonymous namespace.
  • Disables -misc-const-correctness warning in 3 cases where it is reported on a variable that cannot be made const.

- disabled -misc-const-correctness warning
- updated function from anonymous namespace to static
@alsepkow
Copy link

That const warning sounds like something nice to have. Do we intend to follow up? Are we submitting a quick fix right now to unblock builds?

@damyanp
Copy link
Collaborator

damyanp commented Nov 21, 2025

That const warning sounds like something nice to have. Do we intend to follow up? Are we submitting a quick fix right now to unblock builds?

// NOLINT(misc-const-correctness) perhaps?

@hekota
Copy link
Member Author

hekota commented Nov 25, 2025

// NOLINT(misc-const-correctness) perhaps?

Thanks for the tip!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants