Update XFAILs of WaveActiveSum tests #527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Icohedron
added
the
test-all
bogner
approved these changes
Dec 1, 2025
Collaborator
bogner
left a comment
bogner
left a comment
There was a problem hiding this comment.
LGTM other than the missing bug link
llvm-beanz
approved these changes
Dec 1, 2025
Collaborator
llvm-beanz
left a comment
llvm-beanz
left a comment
There was a problem hiding this comment.
One comment, feel free to take or leave it.
farzonl
approved these changes
Dec 1, 2025
bogner
reviewed
Dec 2, 2025
| # XFAIL: WARP && Clang | ||
|
|
||
| # Bug https://github.com/llvm/offload-test-suite/issues/525 | ||
| # XFAIL: NV && Clang & DirectX |
Collaborator
There was a problem hiding this comment.
Typo here. I've gone ahead and merged a fix: #536
Suggested change
| # XFAIL: NV && Clang & DirectX | |
| # XFAIL: NV && Clang && DirectX |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the Clang XFAIL to a Vulkan && Clang XFAIL since the related issue (llvm/llvm-project#156775) appears to only be related to SPIR-V.
Also adds additional XFAILs for machines that still fail the tests.
Confirmed all Vulkan && Clang workflows XFAIL:
The remaining XFAILs are under D3D12 with Clang, mostly on NVIDIA and WARP. Most of the Metal XFAILs are expected except fp32 because fp32 passes with DXC.