Skip to content

Wheels for Windows only get build for Python 3.11 #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marbre opened this issue Jan 23, 2025 · 0 comments
Open

Wheels for Windows only get build for Python 3.11 #10

marbre opened this issue Jan 23, 2025 · 0 comments

Comments

@marbre
Copy link
Member

marbre commented Jan 23, 2025

While py_version is set to build for different Python versions, the value isn't used to set up the runners accordingly. Instead, Python 3.11 is installed on windows-2022 runners by default and as a result wheels get build for Python 3.11, even though py_version is set to cp310-cp310, see https://github.com/llvm/torch-mlir-release/actions/runs/12927777177/job/36053656593#step:5:101. To fix this, the correct Python version needs to be installed, based on what py_version is set to. As an example, IREE does this via its build_tools/python_deploy/install_windows_deps.ps1 script. Furthermore, the Python version should be checked before kicking off the build, see for example how this is handled in IREE in build_tools/python_deploy/build_windows_packages.ps1#L33-L46.

marbre added a commit to marbre/torch-mlir-release that referenced this issue Jan 23, 2025
All other build default to Python 3.11 with the only difference that the
artifact name includes a Python version but the artifact itself does not
contain a build for that version, see llvm#10.
marbre added a commit to marbre/torch-mlir-release that referenced this issue Jan 23, 2025
All other build default to Python 3.11 with the only difference that the
artifact name includes a Python version but the artifact itself does not
contain a build for that version, see llvm#10.
marbre added a commit that referenced this issue Jan 24, 2025
All other build default to Python 3.11 with the only difference that the
artifact name includes a Python version but the artifact itself does not
contain a build for that version, see #10.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant