Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: manually update PyTorch version #3919

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

vivekkhandelwal1
Copy link
Collaborator

This commit sets the PyTorch and TorchVision version to nightly release 2024-12-16.

This commit adds the support for aten.rrelu_with_noise_functional op by decomposing it. And, also updates the existing decomposition of aten.rrelu_with_noise op by decomposing it to the newly added aten.rrelu_with_noise_functional op. It also updates the e2e tests for aten.rrelu_with_noise op by replacing it with its functional variant which is added here: pytorch/pytorch@f85e238 and which captures the noise mutation which was earlier a reason for the test failures during the training mode.

This commit also removes the newly passing tests from the xfail_sets.

Copy link
Collaborator

@jinchen62 jinchen62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@zjgarvey zjgarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

This commit sets the PyTorch and TorchVision version to nightly release
2024-12-16.

This commit adds the support for `aten.rrelu_with_noise_functional`
op by decomposing it. And, also updates the existing decomposition of
`aten.rrelu_with_noise` op by decomposing it to the newly added
`aten.rrelu_with_noise_functional` op. It also updates the e2e tests
for `aten.rrelu_with_noise` op by replacing it with its functional
variant which is added here: pytorch/pytorch@f85e238
and which captures the noise mutation which was earlier a reason for
the test failures during the training mode.

This commit also removes the newly passing tests from the xfail_sets.

Signed-off-by: Vivek Khandelwal <vivekkhandelwal1424@gmail.com>
@vivekkhandelwal1 vivekkhandelwal1 enabled auto-merge (squash) December 20, 2024 05:48
@vivekkhandelwal1 vivekkhandelwal1 merged commit a6179c0 into llvm:main Dec 20, 2024
3 checks passed
@vivekkhandelwal1 vivekkhandelwal1 deleted the roll-pytorch branch December 20, 2024 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants