[Torch] add aten.bilinear op decomposing #3931
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @vivekkhandelwal1. I don't have permission to request review yet. Do you mind taking a look at this change? Thanks! |
sahas3
reviewed
Dec 23, 2024
| @@ -7655,6 +7678,78 @@ class DecomposeAtenLinearOp : public OpRewritePattern<AtenLinearOp> { | |||
| }; | |||
| } // namespace | |||
|
|
|||
| namespace { | |||
| // Decompose `aten.bilinear` op into `aten._trilinear` and `aten.add` ops. | |||
| class DecomposeAtenBilinearOp : public OpRewritePattern<AtenBilinearOp> { | |||
There was a problem hiding this comment.
Can you please add some code-snippet as comment here to show how the decomposition looks like?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
aten.bilinearop. Theaten.bilinearop is decomposed toaten._trilinearandaten.addaccording to https://github.com/pytorch/pytorch/blob/main/aten/src/ATen/native/Linear.cpp#L712.Additionally, this PR fixes a bug in
aten._trilinearop decomposition about tensor shape mismatch.