Resource initialization proposal update - add static init methods #336

hekota · 2025-09-03T00:13:32Z

Renames 0025-resource-constructors.md to 0025-resource-initialization-and-constructors.md
Adds static methods __createFromBinding and __createFromImplicitBinding that will be used to initialize resource classes
Removes resource constructors with binding information
Updates naming of builtins to match implementation
Updates description of copy constructor and assignment operator
Updates references and text in other proposals to match

proposals/0024-implicit-resource-binding.md

…tbinding (#155861) Reorder the arguments of `__builtin_hlsl_resource_handlefromimplicitbinding` builtins to match the order of the `llvm.dx.resource.handlefromimplicitbinding` intrinsics, and also to match the arguments on the static create methods for resource initialization ([described here](llvm/wg-hlsl#336)). Previously the arguments were in the same order as the resource class constructor for implicit binding. The `orderId` argument was intentionally at index `3` to make sure explicit & implicit binding constructors have different signature. Since we are going to replace the constructors that have binding info with static create methods, this is no longer necessary, and it is better for the argument order to match. Related to #154221.

…fromimplicitbinding (#155861) Reorder the arguments of `__builtin_hlsl_resource_handlefromimplicitbinding` builtins to match the order of the `llvm.dx.resource.handlefromimplicitbinding` intrinsics, and also to match the arguments on the static create methods for resource initialization ([described here](llvm/wg-hlsl#336)). Previously the arguments were in the same order as the resource class constructor for implicit binding. The `orderId` argument was intentionally at index `3` to make sure explicit & implicit binding constructors have different signature. Since we are going to replace the constructors that have binding info with static create methods, this is no longer necessary, and it is better for the argument order to match. Related to #154221.

bogner

Generally looks good. A few minor notes.

Also, on a very pedantic level, from a language definition point of view C++ (and thus HLSL) doesn't really have "methods", but uses the term "member functions". For the purpose of these documents I think the term "method" is well known enough that it doesn't really matter, but we probably want to be careful about this if it comes to describing any of this in the language standard itself.

bogner · 2025-09-08T17:28:44Z

proposals/0025-resource-initialization-and-constructors.md

+referred to as _resource classes_ or _resource records_. These terms can be used
+interchangeably.
+
+The record classes can be declared at the global scope, used as function in/out


Should "record classes" here be one of "resource structs", "resource classes", or "resource records", as defined above?

bogner · 2025-09-08T17:34:36Z

proposals/0025-resource-initialization-and-constructors.md

+`__builtin_hlsl_resource_handlefrombinding` Clang builtin function will be used
+to infer the return type of that function. This is the same way we infer return
+types for HLSL intrinsic builtins based on their arguments, except in the case
+only the type of the argument is used and not its (uninitialized) value.


Note that saying the value here is uninitialized implies that the default constructor (as mentioned above) specifically does not initialize the handle. This is mostly true, as initializing to poison as described in the section on the default constructor is morally equivalent to uninitialized, but we may need to take care that we aren't generating redundant intrinsic calls for initialization in these initializer functions.

s-perron

LGTM. This will be easier to work with. Thanks.

s-perron · 2025-09-08T18:43:55Z

proposals/0025-resource-initialization-and-constructors.md

+
+`RWBuffer<float> A = RWBuffer<float>::__createFromImplicitBinding(0,13,1,0,"A");`.
+
+### Resources with dynamic binding


What is dynamic binding? I'm curious.

Resources that have binding assigned at runtime: https://microsoft.github.io/DirectX-Specs/d3d/HLSL_SM_6_6_DynamicResources.html

proposals/0025-resource-initialization-and-constructors.md

Adds static methods `__createFromBinding` and `__createFromImplicitBinding` to resource classes. These methods will be used for resource initialization instead of resource constructors that take binding information. Updated proposal: llvm/wg-hlsl#336

…5866) Adds static methods `__createFromBinding` and `__createFromImplicitBinding` to resource classes. These methods will be used for resource initialization instead of resource constructors that take binding information. Updated proposal: llvm/wg-hlsl#336

…156544) Use static methods `__createFromBinding` and `__createFromImplicitBinding` to initialize individual resources in Sema HLSL instead of calling resource constructor with binding information per proposal update llvm/wg-hlsl#336. Initialization of resources in arrays will be updated in a separate change because that happens in the codegen layer. Test updates include the use of the `llvm-cxxfilt` tool which takes care of demangling of function names for a more readable test baseline.

…resources (#156544) Use static methods `__createFromBinding` and `__createFromImplicitBinding` to initialize individual resources in Sema HLSL instead of calling resource constructor with binding information per proposal update llvm/wg-hlsl#336. Initialization of resources in arrays will be updated in a separate change because that happens in the codegen layer. Test updates include the use of the `llvm-cxxfilt` tool which takes care of demangling of function names for a more readable test baseline.

…157005) Use static methods `__createFromBinding` and `__createFromImplicitBinding` to initialize resources in resource arrays instead of calling resource constructors with binding information, per proposal update llvm/wg-hlsl#336. Test updates include the use of the `llvm-cxxfilt` tool which takes care of demangling of function names for a more readable test baseline.

…n arrays (#157005) Use static methods `__createFromBinding` and `__createFromImplicitBinding` to initialize resources in resource arrays instead of calling resource constructors with binding information, per proposal update llvm/wg-hlsl#336. Test updates include the use of the `llvm-cxxfilt` tool which takes care of demangling of function names for a more readable test baseline.

Removes resource constructors that take binding information per proposal update llvm/wg-hlsl#336. The constructors are replaced by static `__createFromBinding` and `__createFromImplicitBinding` methods on the resource class.

Update resource initialization proposal with static create methods

325cab2

hekota mentioned this pull request Sep 2, 2025

[HLSL] Change resource initialization to use static create methods llvm/llvm-project#154221

Closed

5 tasks

hekota commented Sep 3, 2025

View reviewed changes

proposals/0024-implicit-resource-binding.md Show resolved Hide resolved

hekota requested a review from bogner September 3, 2025 00:21

hekota mentioned this pull request Sep 3, 2025

[HLSL] Reorder arguments of __builtin_hlsl_resource_handlefromimplicitbinding llvm/llvm-project#155861

Merged

hekota linked an issue Sep 3, 2025 that may be closed by this pull request

[HLSL] Change resource initialization to use static create methods llvm/llvm-project#154221

Closed

5 tasks

hekota marked this pull request as draft September 3, 2025 19:42

Update create methods body, remove handle constructor, fix grammar

c3d7d3b

hekota requested a review from s-perron September 4, 2025 23:05

hekota changed the title ~~Update resource initialization proposal~~ Resource initialization proposal update - add static init methods Sep 4, 2025

hekota marked this pull request as ready for review September 4, 2025 23:06

hekota mentioned this pull request Sep 4, 2025

[HLSL] Add static methods for resource initialization llvm/llvm-project#155866

Merged

bogner approved these changes Sep 8, 2025

View reviewed changes

s-perron approved these changes Sep 8, 2025

View reviewed changes

code review feedback

b62ef34

hekota merged commit 533cb2a into llvm:main Sep 9, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Resource initialization proposal update - add static init methods #336

Resource initialization proposal update - add static init methods #336

Uh oh!

hekota commented Sep 3, 2025 •

edited

Loading

Uh oh!

Uh oh!

bogner left a comment

Uh oh!

bogner Sep 8, 2025

Uh oh!

bogner Sep 8, 2025

Uh oh!

s-perron left a comment

Uh oh!

s-perron Sep 8, 2025

Uh oh!

hekota Sep 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants


		`RWBuffer<float> A = RWBuffer<float>::__createFromImplicitBinding(0,13,1,0,"A");`.

		### Resources with dynamic binding

Resource initialization proposal update - add static init methods #336

Resource initialization proposal update - add static init methods #336

Uh oh!

Conversation

hekota commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

bogner left a comment

Choose a reason for hiding this comment

Uh oh!

bogner Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

bogner Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

s-perron left a comment

Choose a reason for hiding this comment

Uh oh!

s-perron Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

hekota Sep 9, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

hekota commented Sep 3, 2025 •

edited

Loading