Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update a new sota model on MT-Bench which touch an 8.8 scores. #2864

Merged
merged 1 commit into from
Dec 28, 2023
Merged

update a new sota model on MT-Bench which touch an 8.8 scores. #2864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fastchat/conversation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1313,7 +1313,7 @@ def get_conv_template(name: str) -> Conversation:
)
)
# xDAN default template
# source: https://huggingface.co/xDAN-AI/xDAN-L1-Chat-v0.1
# source: https://huggingface.co/xDAN-AI/xDAN-L1-Chat-RL-v1
register_conv_template(
Conversation(
name="xdan-v1",
Expand Down
4 changes: 2 additions & 2 deletions fastchat/model/model_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1983,10 +1983,10 @@ def get_default_conv_template(self, model_path: str) -> Conversation:


class XdanAdapter(BaseModelAdapter):
"""The model adapter for xDAN-AI (e.g. xDAN-AI/xDAN-L1-Chat-v0.1)"""
"""The model adapter for xDAN-AI (e.g. xDAN-AI/xDAN-L1-Chat-RL-v1)"""

def match(self, model_path: str):
return "xdan" in model_path.lower()
return "xdan" in model_path.lower() and "v1" in model_path.lower()

def get_default_conv_template(self, model_path: str) -> Conversation:
return get_conv_template("xdan-v1")
Expand Down
4 changes: 2 additions & 2 deletions fastchat/model/model_registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -510,9 +510,9 @@ def get_model_info(name: str) -> ModelInfo:
)

register_model_info(
["xDAN-L1-Chat-v0.1"],
["xDAN-L1-Chat-RL-v1"],
"xDAN-L1-Chat",
"https://huggingface.co/xDAN-AI/xDAN-L1-Chat-v0.1",
"https://huggingface.co/xDAN-AI/xDAN-L1-Chat-RL-v1",
"A large language chat model created by xDAN-AI.",
)

Expand Down