Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Update all screenshots of visual tests, because there is a new Inter font release #1567

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

crishpeen
Copy link
Member

Apparently Google Fonts released a new version of Inter font (they finally used v4 which Rasmus released in November). This version has different kerning among other things. This broke our visual tests and we have to update them all now with the new font.

Source:
google/fonts#7985
google/fonts#3429
google/fonts#7776
https://github.com/rsms/inter/releases/tag/v4.0

Description

Additional context

Issue reference

@crishpeen crishpeen added the run-visual-tests Runs visual regression testing on this PR label Aug 6, 2024
@crishpeen crishpeen requested a review from a team as a code owner August 6, 2024 09:00
@github-actions github-actions bot added the bug Something isn't working label Aug 6, 2024
Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 6e2850f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/66b1e63cb7836e00085a64d1

Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 6e2850f
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/66b1e63ca0daf00008b524e6
😎 Deploy Preview https://deploy-preview-1567--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 93 (no change from production)
Best Practices: 100 (no change from production)
SEO: 82 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@coveralls
Copy link

Coverage Status

coverage: 78.194%. remained the same
when pulling 6e2850f on fix/update-screenshots-inter-4
into cc622c3 on main.

@crishpeen crishpeen merged commit 205e189 into main Aug 6, 2024
17 checks passed
@crishpeen crishpeen deleted the fix/update-screenshots-inter-4 branch August 6, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants