Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Introduce UNSTABLE Header & Navigation #1808

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Feat: Introduce UNSTABLE Header & Navigation #1808

wants to merge 7 commits into from

Conversation

crishpeen
Copy link
Member

Description

Additional context

Issue reference

@netlify Netlify
Copy link

netlify bot commented Dec 10, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit 04df787
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/677e8563c226e100080c0beb

@netlify Netlify
Copy link

netlify bot commented Dec 10, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 04df787
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/677e85631b23730008b20e2c
😎 Deploy Preview https://deploy-preview-1808--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@crishpeen crishpeen added run-visual-tests Runs visual regression testing on this PR feature New feature or request labels Dec 10, 2024
@crishpeen crishpeen force-pushed the integration/header branch 2 times, most recently from e1a591b to fbe9985 Compare December 17, 2024 12:53
@crishpeen crishpeen mentioned this pull request Dec 17, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/12373418568/artifacts/2331849796

@coveralls
Copy link

Coverage Status

coverage: 79.469%. remained the same
when pulling fc5ceb3 on integration/header
into a9fee8e on main.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/12670274898/artifacts/2401147495

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@literat literat Awaiting requested review from literat literat will be requested when the pull request is marked ready for review literat is a code owner

@pavelklibani pavelklibani Awaiting requested review from pavelklibani pavelklibani will be requested when the pull request is marked ready for review pavelklibani is a code owner

@curdaj curdaj Awaiting requested review from curdaj curdaj will be requested when the pull request is marked ready for review curdaj is a code owner

@adamkudrna adamkudrna Awaiting requested review from adamkudrna adamkudrna will be requested when the pull request is marked ready for review adamkudrna is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@crishpeen crishpeen

Labels
feature New feature or request run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crishpeen @coveralls @curdaj