Feat: Normalize template name using regex to allow capitalized prefixes #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
literat
requested review from
adamkudrna,
crishpeen,
pavelklibani,
curdaj,
janicekt and
OndraM
curdaj
approved these changes
Jun 12, 2024
OndraM
reviewed
Jun 12, 2024
literat
force-pushed
the
feat/unstable-prefix
branch
from
1673375
to
5562828
Compare
* prefixes in format `PREFIX_` for template name can now be used * it will normalize the template name to lower case - `prefix_` * motivation is to allowed `UNSTABLE_` prefix name for our components
literat
force-pushed
the
feat/unstable-prefix
branch
from
5562828
to
d1d1702
Compare
crishpeen
reviewed
Jun 13, 2024
| @@ -146,6 +152,13 @@ function (array $matches) { | |||
| ); | |||
| } | |||
|
|
|||
| private function normalizeComponentPathName(string $name): string | |||
There was a problem hiding this comment.
shouldn't we test this too? At least it would help me understand it what it does :D
There was a problem hiding this comment.
The test was modified to cover this change. However, the private methods cannot be tested directly. 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PREFIX_for template name can now be usedprefix_UNSTABLE_prefix name for our components