Fix non-deterministic search #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy over the following functions from UMAP master (ab7f27d): build_candidates, new_build_candidates and make_nn_descent.
|
@pavlin-policar I've turned your code to reproduce this issue into a unit test in #14. It has been fixed by #12, so this PR may no longer be needed. I've also started work on harmonizing the the common code between umap and pynndescent (see #13), with the aim of ultimately removing the duplication entirely by making umap depend on pynndescent. |
|
Awesome, thanks! |
|
Thanks @tomwhite! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10.
Copy over the following functions from UMAP master (ab7f27d):
build_candidates,new_build_candidatesandmake_nn_descent.Honestly, I didn't look at the code at all, nor did I delve into how the method works. But I took the code for the problematic functions from the UMAP repository, which appears to be a fair bit ahead of this repository, and put it here and, voilà, it works.
I did identify the problem being the
parallel=Truedirective in the oldbuild_candidates. It seem that it was found and fixed a while ago in UMAP.