Support CEREBRO_PORT environment variable #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per my issue here, I'd like to be able to change the cerebro port at runtime.
This would allow the use of cerebro within a Kubernetes cluster without port clashes. This is quite common for docker containers.
I've made some changes to the Dockerfile to swap to using an
entrypoint.sh
file which reads from the environment variableCEREBRO_PORT
- this will default to 9000 if not specified (so it remains compatible).I don't see any compatibility breakages here, my slight concern is dropping the
EXPOSE
command in the Dockerfile - but as this is optional (and the existing instructions get the user to specify this manually), I believe it's superfluous.