Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow to select kind of shard allocation in overview #423

Merged
merged 1 commit into from
Apr 24, 2020

Conversation

simioa
Copy link
Contributor

@simioa simioa commented Jan 17, 2020

This PR allows users to select the kind of shard allocation when clicking on the lock symbol in the overview dashboard.

When the Lock Symbol is clicked, a dropdown menu opens where the user can select the kind of shard allocation.

lock_kind

@moliware
Copy link
Collaborator

Looks good to me. I will release this on friday (unless @lmenezes says otherwise)

Thanks for contributing.

@moliware moliware merged commit 0ed426c into lmenezes:master Apr 24, 2020
@zolech
Copy link

zolech commented Aug 28, 2020

Hi. I realize that it is already too late but there is no option for "all" shards. Right now after disabling shard allocation I have to enable it manually by rest request. Could you add an option for "all" shards like it was before ?

@simioa
Copy link
Contributor Author

simioa commented Sep 1, 2020

Hi @zolech
The functionality for allocation on "all" did not change. Clicking on the closed Lock Symbol will enable allocation on "all" as it was before.

@zolech
Copy link

zolech commented Sep 1, 2020

Hi @zolech
The functionality for allocation on "all" did not change. Clicking on the closed Lock Symbol will enable allocation on "all" as it was before.

Hi. Clicking on lock icon gives me menu with 3 items as in first post in this topic. I can disable allocation with option "none" but after clicking again I get the same menu with these three items and I have to chose one of them. I doesn't enable allocation with "all" option by default.

@simioa
Copy link
Contributor Author

simioa commented Sep 1, 2020

Which browser are you using? Can you clear the browser cache and try it again? It works for me in Chrome, Edge and Safari

@zolech
Copy link

zolech commented Sep 1, 2020

Google chrome, but I also tried in firefox, incognito, clear cache etc. The lock icon also stays open all the time even after selecting "none". I've upgraded to v0.9.2 but nothing changed.

Here is the moment when I click on an icon and can only select from 3 menu positions:
chrome-capture

@simioa
Copy link
Contributor Author

simioa commented Sep 1, 2020

Unfortunately I'm not able to reproduce this using the latest Docker Image, it still works as expected.
Does clicking on one of the elements actually change the Allocation Kind on the Cluster?

Can you have a look into the Chrome DevTools Network Tab while clicking on the button? After clicking the Button a transaction with the name "disable_shard_allocation" should appear with status 200.
Can you confirm that this happens? If so, can you please click on that transaction and paste the output of the preview tab here?

@zolech
Copy link

zolech commented Sep 1, 2020

Does clicking on one of the elements actually change the Allocation Kind on the Cluster?

Yes, I can see it in logs: updating [cluster.routing.allocation.enable] from [new_primaries] to [none]

Can you have a look into the Chrome DevTools Network Tab while clicking on the button? After clicking the Button a transaction with the name "disable_shard_allocation" should appear with status 200.
Can you confirm that this happens? If so, can you please click on that transaction and paste the output of the preview tab here?

There is no transaction after just hitting the button, only menu appears. Transaction happens only after selecting position from menu and here is the output from dev tools:

{status:` 200,…}
body: {acknowledged: true, persistent: {}, transient: {cluster: {routing: {allocation: {enable: "none"}}}}}
acknowledged: true
persistent: {}
transient: {cluster: {routing: {allocation: {enable: "none"}}}}
cluster: {routing: {allocation: {enable: "none"}}}
routing: {allocation: {enable: "none"}}
allocation: {enable: "none"}
enable: "none"
status: 200

@simioa
Copy link
Contributor Author

simioa commented Sep 1, 2020

After selecting one of the elements from the list, in this case you clicked on "none", did the Lock Symbol change to a closed Lock Symbol? If so, clicking on the closed Lock Symbol should change the allocation kind back to "all".

@zolech
Copy link

zolech commented Sep 1, 2020

No, it never changes to closed lock.

EDIT: I've made additional tests on IE, Edge, also my colleagues tried that and it also never changes.

@moliware
Copy link
Collaborator

moliware commented Sep 2, 2020

@zolech could you open an issue about this problem?
Thanks!

@zolech
Copy link

zolech commented Sep 2, 2020

Yes, now when I'm sure that it is not intended behavior I can proceed with and issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants