-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow to select kind of shard allocation in overview #423
Conversation
Looks good to me. I will release this on friday (unless @lmenezes says otherwise) Thanks for contributing. |
Hi. I realize that it is already too late but there is no option for "all" shards. Right now after disabling shard allocation I have to enable it manually by rest request. Could you add an option for "all" shards like it was before ? |
Hi @zolech |
Hi. Clicking on lock icon gives me menu with 3 items as in first post in this topic. I can disable allocation with option "none" but after clicking again I get the same menu with these three items and I have to chose one of them. I doesn't enable allocation with "all" option by default. |
Which browser are you using? Can you clear the browser cache and try it again? It works for me in Chrome, Edge and Safari |
Unfortunately I'm not able to reproduce this using the latest Docker Image, it still works as expected. Can you have a look into the Chrome DevTools Network Tab while clicking on the button? After clicking the Button a transaction with the name "disable_shard_allocation" should appear with status 200. |
Yes, I can see it in logs: updating [cluster.routing.allocation.enable] from [new_primaries] to [none]
There is no transaction after just hitting the button, only menu appears. Transaction happens only after selecting position from menu and here is the output from dev tools:
|
After selecting one of the elements from the list, in this case you clicked on "none", did the Lock Symbol change to a closed Lock Symbol? If so, clicking on the closed Lock Symbol should change the allocation kind back to "all". |
No, it never changes to closed lock. EDIT: I've made additional tests on IE, Edge, also my colleagues tried that and it also never changes. |
@zolech could you open an issue about this problem? |
Yes, now when I'm sure that it is not intended behavior I can proceed with and issue. |
This PR allows users to select the kind of shard allocation when clicking on the lock symbol in the overview dashboard.
When the Lock Symbol is clicked, a dropdown menu opens where the user can select the kind of shard allocation.