Typo in _buildmodel dict restore (Fixes #956) #957
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Correct typo in
_buildmodel
dict restore (Fixes #956)The issue only manifested on
Voigt
andSkewedVoigt
models for me, not sure if you want to change thetest_model_saveload.test_save_load_model
code just to catch this.Type of Changes
Tested on
lmfit: 1.3.1.post0+g3cfd09a.d20240510, scipy: 1.13.0, numpy: 1.26.4, asteval: 0.9.32, uncertainties: 3.1.7
Verification
Have you