ensure that correct initial params are used when re-fitting a ModelResult

[newville]

This fixes #960 and #954.

Type of Changes

• Bug fix
• New feature
• Refactoring / maintenance
• Documentation / examples

Tested on

Python: 3.11.5 | packaged by conda-forge | (main, Aug 27 2023, 03:35:23) [Clang 15.0.7 ]

lmfit: 1.3.1.post8+gb72cfb28.d20240713, scipy: 1.13.1, numpy: 1.26.4, asteval: 1.0.1, uncertainties: 3.2.2

Verification

Have you

• included docstrings that follow PEP 257?

• referenced existing Issue and/or provided relevant link to mailing list?

• verified that existing tests pass locally?

• verified that the documentation builds locally?

• squashed/minimized your commits and written descriptive commit messages?

• added or updated existing tests to cover the changes?
• updated the documentation and/or added an entry to the release notes (doc/whatsnew.rst)?
• added an example?

[codecov]

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.18%. Comparing base (b72cfb2) to head (69db101).

Files	Patch %	Lines
lmfit/model.py	71.42%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #961      +/-   ##
==========================================
- Coverage   93.20%   93.18%   -0.02%     
==========================================
  Files          10       10              
  Lines        3765     3769       +4     
==========================================
+ Hits         3509     3512       +3     
- Misses        256      257       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[newville]

@reneeotten If you agree, I think squash-merging this would allow tagging and pushing version 1.3.2.

[newville]

@reneeotten I'm going to (squash) merge this and tag and push as 1.3.2

[reneeotten]

@reneeotten I'm going to (squash) merge this and tag and push as 1.3.2

sorry @newville and thanks for fixing this! Between work and a newborn there isn't too much time for this at the moment... 😉

[newville]

@reneeotten No worries (I hear you!). And also: Congratulations!