Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark docstrings with backslashes as raw strings #226

Merged
merged 1 commit into from
May 16, 2024

Conversation

wshanks
Copy link
Collaborator

@wshanks wshanks commented May 16, 2024

This change avoids Python issuing a SyntaxWarning about an unrecognized escape sequence. The only occurrences were in one test file.

Note that some strings had a u prefix replaced with r. The u
prefix was needed for Python 2. These strings did not work with a ur
prefix. Since Python 2 is no longer supported, no other means of keeping
support with Python 2 was attempted.

This change avoids Python issuing a SyntaxWarning about an unrecognized
escape sequence. The only occurrences were in one test file.

Note that some strings had a `u` prefix replaced with `r`. The `u`
prefix was needed for Python 2. These strings did not work with a `ur`
prefix. Since Python 2 is no longer supported, no other means of keeping
support with Python 2 was attempted.
@wshanks wshanks force-pushed the docstring-escapes branch from 6becfd4 to 561281e Compare May 16, 2024 14:21
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.74%. Comparing base (3255816) to head (561281e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #226   +/-   ##
=======================================
  Coverage   95.74%   95.74%           
=======================================
  Files          12       12           
  Lines        1905     1905           
=======================================
  Hits         1824     1824           
  Misses         81       81           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@newville newville mentioned this pull request May 16, 2024
Copy link
Member

@newville newville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@newville
Copy link
Member

@wshanks I am +1 on just merging this. Any objections?

@wshanks
Copy link
Collaborator Author

wshanks commented May 16, 2024

@wshanks I am +1 on just merging this. Any objections?

Not from me 🙂

@andrewgsavage andrewgsavage merged commit cbf4917 into lmfit:master May 16, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants