-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make uncertainties compatible with numpy 2.0 #245
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #245 +/- ##
==========================================
- Coverage 48.34% 48.31% -0.03%
==========================================
Files 12 12
Lines 1903 1902 -1
==========================================
- Hits 920 919 -1
Misses 983 983 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eendebakpt Thanks! I agree.
Separately: I wonder if we should explicitly test with both numpy 1.2something and numpy 2.0.... but that should not be necessary here, as this probably does really warrant a bugfix release for numpy2 users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now!
@newville We effectively do test on numpy 1 and 2 because we test on Python 3.8 and numpy 2.0 only supports Python 3.9+. We may want to set deprecation warnings as test failures, or maybe just deal with the numpy.matrix pending deprecation warnings. I think I missed this deprecation warning about numpy.core amongst all the numpy.matrix pending deprecation warnings when I tested with numpy 2.0 before. |
@reneeotten @eendebakpt Thanks! @wshanks good point about Py38 being pinned to Numpy1. I am okay with leaving this as it is. |
please squash the commits and update the commit message. |
In numpy 2.0 the
numpy.core
was renamed tonumpy._core
. Is this PR we change the imports in theuncertainties
package to work with both numpy 2.0 and numpy 1.x.