Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codecov updates #246

Merged
merged 3 commits into from
Jul 7, 2024
Merged

Codecov updates #246

merged 3 commits into from
Jul 7, 2024

Conversation

newville
Copy link
Member

@newville newville commented Jul 4, 2024

This updates the .codecov.yml file to be (I believe!) more compliant with codecov expectations.
And it changes the invocation of pytest with coverage in the testing environment.

Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.74%. Comparing base (4b309a6) to head (e44e6b2).

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #246       +/-   ##
===========================================
+ Coverage   48.31%   95.74%   +47.42%     
===========================================
  Files          12       12               
  Lines        1902     1902               
===========================================
+ Hits          919     1821      +902     
+ Misses        983       81      -902     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

add test folder to coverage report, print coverage report to terminal for better Actions output

Co-authored-by: Will Shanks <wshaos@posteo.net>
Copy link
Collaborator

@wshanks wshanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@newville
Copy link
Member Author

newville commented Jul 6, 2024

@wshanks Thanks. If there are no objections (@andrewsavage @jagerber48), I suggest you squash and merge this. We could then tag and release 3.2.2, and push to PyPI.

  • fixing support for Numpy2.
  • showing more realistic coverage stats.

@andrewgsavage
Copy link
Contributor

nice, go for it

@wshanks wshanks merged commit 411ce33 into master Jul 7, 2024
18 checks passed
@wshanks wshanks deleted the codecov_updates branch July 7, 2024 11:58
@wshanks wshanks mentioned this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants