-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix small float formatting #290
Fix small float formatting #290
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #290 +/- ##
==========================================
- Coverage 96.55% 96.55% -0.01%
==========================================
Files 17 17
Lines 1947 1946 -1
==========================================
- Hits 1880 1879 -1
Misses 67 67
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #290 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @OceanNuclear, I think this is all okay.
I will also say that UFloats with a stderr of zero (or less that 2e-16*nominal_value) basically make no sense and will likely cause problems. A value with a (finite) uncertainty can be represented as a UFloat. A value with an infinitesimal uncertainty is a Float. I find it odd how much attention UFloats with stderr=0 get.
I will also say that all of the formatting code in uncertainties
is a distraction from the main point of the library.
And yet, I'll go with a bit of a shrug and hearty thanks @OceanNuclear for the fix to this very warty part of the code.
@OceanNuclear merging... thanks! |
Glad to be of help! |
Fixed the edge case of having super-small (but non-zero) AffineFunc expressed as str.
pre-commit run --all-files
with no errors