-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up pow
tests
#292
Clean up pow
tests
#292
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #292 +/- ##
==========================================
+ Coverage 96.55% 96.71% +0.15%
==========================================
Files 17 18 +1
Lines 1946 1886 -60
==========================================
- Hits 1879 1824 -55
+ Misses 67 62 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
CodSpeed Performance ReportMerging #292 will not alter performanceComparing Summary
|
@jagerber48 Thanks - this looks like an improvement in readability to me! I do worry a bit about a test with It looks like that is only used to test that using that as an exponent yields a stderr of NaN. That's OK. +1 on merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
I'll double check that all cases are copied over correctly for now and then merge it in.
Definitely interested in this idea since it's tests like these that have been giving me a lot of trouble on #262 and caused to me raise #283. We can discuss elsewhere. I'll keep this PR as a simple 1:1 test refactor. |
pre-commit run --all-files
with no errorsSummary of goals:
pytest.mark.parametrize
. Hopefully this makes the tests more readable.pow
andumath_core.pow
in atest_power.py
module to get some code re-use and to combine similar tests rather than spread them across modulespow
test code fromhelpers.py
module.