Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Correct melting and boiling points for Carbon allotropes #214

Merged
merged 9 commits into from
Dec 28, 2024

Conversation

lmmentel
Copy link
Owner

@lmmentel lmmentel commented Dec 22, 2024

Fixes #212

Proposed Changes

  • Drop melting points from PhaseTransition for carbon allotropes (graphite and diamond) since they are not at starndard pressueres.
  • Add is_sublimation_point to PhaseTransition where boiling point is a sublimation point
  • Add is_transition to PhaseTransition where melting point is a phase transition to the crystalline form.
  • Element.melting_point and Element.boiling_point consistently return either a float or None

After the changes

>>> from mendeleev import C
>>> print(C.melting_point)
None
>>> print(C.boiling_point)
4098.15
>>> print(C.phase_transitions)
[PhaseTransition(atomic_number=6, allotrope=graphite, melting_point=None, boiling_point=4098.15, triple_point_temperature=4762.15, triple_point_pressure=10300.0, critical_temperature=None, pritical_pressure=None, is_sublimation_point=True, is_transition=None)]

@lmmentel lmmentel self-assigned this Dec 22, 2024
@lmmentel lmmentel added data Data update bugfix labels Dec 22, 2024
@lmmentel lmmentel changed the title [FIX] Correct metling and boiling points for Carbon allotropes [FIX] Correct melting and boiling points for Carbon allotropes Dec 22, 2024
mendeleev/models.py Fixed Show fixed Hide fixed
mendeleev/models.py Dismissed Show dismissed Hide dismissed
mendeleev/models.py Dismissed Show dismissed Hide dismissed
@lmmentel lmmentel merged commit 3d4b1ca into master Dec 28, 2024
20 checks passed
@lmmentel lmmentel deleted the fix/melting-boling-points branch December 28, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix data Data update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent presentation of thermophysical properties
1 participant