Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicit mapping in labels #135

Merged
merged 2 commits into from
Nov 1, 2024
Merged

explicit mapping in labels #135

merged 2 commits into from
Nov 1, 2024

Conversation

skull8888888
Copy link
Collaborator

@skull8888888 skull8888888 commented Nov 1, 2024

Important

Refactor label value handling by changing valueMap to Record<string, number> and update related components and styles.

  • Behavior:
    • Change valueMap from string[] to Record<string, number> in LabelClass and SpanLabel in types.ts.
    • Update label value handling in AddLabel, AddLabelInstance, and SpanLabels to use the new valueMap structure.
    • Ensure duplicate numerical values are not allowed in AddLabel.
  • UI Components:
    • Modify EvaluatorEditor, AddLabelPopover, and AddLabel to map over Object.entries(labelClass.valueMap) instead of labelClass.valueMap.
    • Update UI to display label keys instead of indices in EvaluatorEditor and AddLabelPopover.
  • Styles:
    • Adjust color variables in globals.css for secondary-foreground, muted-foreground, and destructive.

This description was created by Ellipsis for 515ac9a. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 515ac9a in 1 minute and 13 seconds

More details
  • Looked at 366 lines of code in 6 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_2pwvsERHuMvKDMU9


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

frontend/components/traces/add-label.tsx Outdated Show resolved Hide resolved
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
@skull8888888 skull8888888 merged commit a3352cd into dev Nov 1, 2024
1 check passed
@skull8888888 skull8888888 deleted the labels branch November 1, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant