overwrite span id when attribute set, query unique traces

[dinmukhamedm]

Important

Ensure unique trace results and allow parent span ID overriding based on attributes in trace.rs and spans.rs.

• Behavior:
  • In get_traces() in trace.rs, added DISTINCT ON (start_time, id) to ensure unique trace results.
  • Modified ORDER BY clause in get_traces() to include id for consistent ordering.
  • In from_otel_span() in spans.rs, set parent_span_id to None if OVERRIDE_PARENT_SPAN_ATTRIBUTE_NAME is true.
• Constants:
  • Added OVERRIDE_PARENT_SPAN_ATTRIBUTE_NAME in spans.rs to manage parent span ID overriding.
• Misc:
  • Updated should_keep_attribute() in spans.rs to exclude OVERRIDE_PARENT_SPAN_ATTRIBUTE_NAME.

^{This description was created by for 5258fea. It will automatically update as commits are pushed.}

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to 5258fea in 1 minute and 0 seconds

More details

• Looked at 61 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. app-server/src/traces/spans.rs:318

• Draft comment:
  The logic to set parent_span_id to None when OVERRIDE_PARENT_SPAN_ATTRIBUTE_NAME is true is correct and consistent with the intended behavior.
• Reason this comment was not posted:
  Confidence changes required: 0%
  The OVERRIDE_PARENT_SPAN_ATTRIBUTE_NAME is correctly used to set parent_span_id to None when the attribute is present and true. This logic is consistent with the intended behavior described in the comments.

Workflow ID: wflow_KYk0nkmPVa2jkwtN

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

The ORDER BY clause should match the columns in the DISTINCT ON clause to ensure consistent results. Consider ordering by start_time, id instead of start_time DESC, id.

Suggested change

	.push(" ORDER BY start_time DESC, id OFFSET ")
	.push(" ORDER BY start_time, id OFFSET ")