Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small redesign of labeling queue #167

Merged
merged 3 commits into from
Nov 6, 2024
Merged

small redesign of labeling queue #167

merged 3 commits into from
Nov 6, 2024

Conversation

skull8888888
Copy link
Collaborator

@skull8888888 skull8888888 commented Nov 6, 2024

Important

Redesigns the labeling queue with backend validation, improved label management, and enhanced UI components.

  • Backend:
    • Add removeQueueItemSchema in route.ts for request validation using zod.
    • Insert new labels to labels table and evaluation scores to evaluationScores table.
    • Remove queue items from labelingQueueItems table.
  • Frontend:
    • Update Labels component in labels.tsx to handle adding and deleting label classes.
    • Redesign Queue component in queue.tsx to display added labels and handle navigation.
    • Remove unused components and code in dataset.tsx and evaluation.tsx.
  • UI Enhancements:
    • Improve label management UI with Popover and DropdownMenu in labels.tsx.
    • Add scrollable areas and formatted display for span input/output in queue.tsx.

This description was created by Ellipsis for b70addd. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to b70addd in 56 seconds

More details
  • Looked at 556 lines of code in 5 files
  • Skipped 1 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. frontend/app/api/projects/[projectId]/queues/[queueId]/remove/route.ts:40
  • Draft comment:
    Check if action is defined before accessing action.resultId to avoid potential runtime errors.
  • Reason this comment was not posted:
    Comment was on unchanged code.
2. frontend/components/queue/queue.tsx:77
  • Draft comment:
    Remove console.log(addedLabels); as it seems to be a leftover from debugging.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    In frontend/components/queue/queue.tsx, the console.log(addedLabels); statement is likely a leftover from debugging and should be removed for cleaner code.

Workflow ID: wflow_YVTsUzR61BpMkk6v


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipped PR review on fee0f61 because no changed files had a supported extension. If you think this was in error, please contact us and we'll fix it right away.

@skull8888888 skull8888888 merged commit caebca1 into dev Nov 6, 2024
1 check passed
@dinmukhamedm dinmukhamedm deleted the labeling-queue branch November 7, 2024 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant