Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update evaluation table schema #190

Merged
merged 1 commit into from
Nov 10, 2024
Merged

update evaluation table schema #190

merged 1 commit into from
Nov 10, 2024

Conversation

dinmukhamedm
Copy link
Member

@dinmukhamedm dinmukhamedm commented Nov 10, 2024

Important

Add timestamp column and update ORDER BY clause in evaluation_scores table in clickhouse/001000-initial.sql.

  • Schema Update:
    • Add timestamp column to evaluation_scores table in clickhouse/001000-initial.sql.
    • Update ORDER BY clause to include timestamp in evaluation_scores table.

This description was created by Ellipsis for f958c16. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to f958c16 in 15 seconds

More details
  • Looked at 18 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. clickhouse/001000-initial.sql:50
  • Draft comment:
    The SETTINGS keyword is repeated. You can combine the settings into a single SETTINGS clause.
SETTINGS index_granularity = 8192, flatten_nested=0;
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_5PQlnIqIA64lw0PJ


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@dinmukhamedm dinmukhamedm merged commit a8a3187 into dev Nov 10, 2024
1 check passed
@dinmukhamedm dinmukhamedm deleted the fix/ch-eval-timestamp branch November 10, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant