fix the manual add datapoint dialog #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to e7d8678 in 1 minute and 28 seconds
More details
- Looked at
76lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_DTPBwvI1hu0BBdIH
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -32,7 +32,7 @@ const CreateDatapointsSchema = z.object({ | |||
| datapoints: z.array(z.object({ | |||
| data: z.unknown(), | |||
| target: z.any().optional(), | |||
| metadata: z.record(z.any()).optional(), | |||
| metadata: z.any().optional(), | |||
There was a problem hiding this comment.
Using z.any() for metadata is too permissive. Consider using a more specific schema to ensure data integrity.
Suggested change
| metadata: z.any().optional(), | |
| metadata: z.object().optional(), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loosen the required restriction on the Zod schema + add a warning on invalid JSONs
Important
Loosen schema restrictions and add JSON validation feedback in manual add datapoint dialog.
metadatafield restriction inCreateDatapointsSchemafromz.record(z.any())toz.any()inroute.ts..required()fromCreateDatapointsSchema.safeParse()inroute.ts.isValidJsonfunction inmanual-add-datapoint-dialog.tsxto check JSON validity and presence ofdatafield.manual-add-datapoint-dialog.tsx.manual-add-datapoint-dialog.tsx.This description was created by
for e7d8678. It will automatically update as commits are pushed.