Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openllmetry seems not to set
gen_ai.system
on OpenAI assistant spans, so our checks don't treat the span as an llm span. While we/traceloop fixes openllmetry loosen our checks a bit.Important
Loosen span type checks in
span_type()
inspans.rs
to classify spans as LLM if attributes start withgen_ai.
orllm.
.span_type()
inspans.rs
to classify spans as LLM if attributes start withgen_ai.
orllm.
.gen_ai.system
is not set on OpenAI assistant spans.This description was created by for f6537ab. It will automatically update as commits are pushed.