Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treat more spans as llm spans #222

Merged
merged 1 commit into from
Nov 19, 2024
Merged

treat more spans as llm spans #222

merged 1 commit into from
Nov 19, 2024

Conversation

dinmukhamedm
Copy link
Member

@dinmukhamedm dinmukhamedm commented Nov 19, 2024

openllmetry seems not to set gen_ai.system on OpenAI assistant spans, so our checks don't treat the span as an llm span. While we/traceloop fixes openllmetry loosen our checks a bit.


Important

Loosen span type checks in span_type() in spans.rs to classify spans as LLM if attributes start with gen_ai. or llm..

  • Behavior:
    • Loosen span type checks in span_type() in spans.rs to classify spans as LLM if attributes start with gen_ai. or llm..
    • Addresses issue where gen_ai.system is not set on OpenAI assistant spans.

This description was created by Ellipsis for f6537ab. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to f6537ab in 11 seconds

More details
  • Looked at 18 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. app-server/src/traces/spans.rs:144
  • Draft comment:
    The logic for determining if a span is an LLM span has been updated to check for keys starting with 'gen_ai.' or 'llm.'. Ensure this change aligns with the intended behavior across the codebase.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR modifies the logic to determine if a span is an LLM span by checking for keys starting with 'gen_ai.' or 'llm.'. This change is in line with the PR description, which mentions loosening the checks to accommodate missing 'gen_ai.system' attributes.

Workflow ID: wflow_oWKJJyWhD2ZvzIBc


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@dinmukhamedm dinmukhamedm merged commit 961fb3f into dev Nov 19, 2024
1 check passed
@dinmukhamedm dinmukhamedm deleted the fix/llm-spans branch November 19, 2024 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant