Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated docs #234

Merged
merged 1 commit into from
Nov 22, 2024
Merged

updated docs #234

merged 1 commit into from
Nov 22, 2024

Conversation

skull8888888
Copy link
Collaborator

@skull8888888 skull8888888 commented Nov 22, 2024

Important

Update documentation and UI components to reflect changes in installation instructions and improve text clarity.

  • Documentation:
    • Update README.md to change Python installation command to pip install --upgrade 'lmnr[all]'.
    • Clarify that all instrumentation packages are installed with the updated command.
  • UI Components:
    • Change default tab in EvalsPagePlaceholder and TracesPagePlaceholder to 'typescript'.
    • Update text in page-placeholder.tsx files to improve clarity and consistency.
    • Adjust tab order in TabsList to show 'typescript' before 'python'.
  • Constants:
    • Update PYTHON_INSTALL in const.ts to pip install 'lmnr[all]'.

This description was created by Ellipsis for 02be91a. It will automatically update as commits are pushed.

@skull8888888 skull8888888 merged commit a9036c1 into dev Nov 22, 2024
1 check passed
@skull8888888 skull8888888 deleted the fix/docs branch November 22, 2024 04:27
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 02be91a in 1 minute and 4 seconds

More details
  • Looked at 385 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. README.md:112
  • Draft comment:
    Ensure that changing the installation command from lmnr[openai] to lmnr[all] is intentional and aligns with the project's requirements. This change will install all instrumentation packages, which might not be necessary for all users.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change from 'lmnr[openai]' to 'lmnr[all]' in the README and code files is consistent, but it should be verified if this is the intended change across the project.
2. frontend/lib/const.ts:5
  • Draft comment:
    Ensure that changing the installation command from lmnr[openai] to lmnr[all] is intentional and aligns with the project's requirements. This change will install all instrumentation packages, which might not be necessary for all users.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change from 'lmnr[openai]' to 'lmnr[all]' in the README and code files is consistent, but it should be verified if this is the intended change across the project.

Workflow ID: wflow_a8KX0E99yqVBRbxo


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant