Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #236

Merged
merged 1 commit into from
Nov 22, 2024
Merged

fix #236

merged 1 commit into from
Nov 22, 2024

Conversation

skull8888888
Copy link
Collaborator

@skull8888888 skull8888888 commented Nov 22, 2024

Important

Fix Formatter component's value prop in queue.tsx to use JSON.stringify() for data.span.output.

  • Behavior:
    • In queue.tsx, Formatter component's value prop for data.span.output is now wrapped with JSON.stringify() to ensure consistent stringified JSON output.

This description was created by Ellipsis for 70bceac. It will automatically update as commits are pushed.

@skull8888888 skull8888888 merged commit b174e28 into dev Nov 22, 2024
1 check passed
@skull8888888 skull8888888 deleted the fix/lq branch November 22, 2024 05:33
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 70bceac in 28 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. frontend/components/queue/queue.tsx:123
  • Draft comment:
    Ensure that data.span.output is always a JSON-serializable object before using JSON.stringify. If not, this could lead to runtime errors.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change in the PR modifies the value prop of the Formatter component to use JSON.stringify(data.span.output). This is consistent with the existing usage for data.span.input, which is also stringified. This suggests the intent is to ensure the Formatter component receives a stringified JSON object, likely for consistent formatting or display purposes.

Workflow ID: wflow_1xVHqZBLo7SGLvq5


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant