do not limit eval time progression graph to 7d #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 91b740c in 25 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_W1V6G1OGQwFZops5
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -16,7 +16,7 @@ export const GET = async (request: NextRequest, { params }: { params: { projectI | |||
| const endDate = new Date(request.nextUrl.searchParams.get('endDate') ?? ''); | |||
| timeRange = { start: startDate, end: endDate }; | |||
| } else { | |||
| timeRange = { pastHours: 168 }; | |||
| timeRange = { pastHours: 'all' }; | |||
There was a problem hiding this comment.
The change from pastHours: 168 to pastHours: 'all' may cause issues since pastHours is expected to be a number. Consider handling the 'all' case differently, perhaps by using a different field or logic to represent an unlimited time range.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Change default time range in
route.tsfrom 7 days to unlimited for evaluation time progression data.timeRangeinGETfunction inroute.tsfrom 7 days (pastHours: 168) to unlimited (pastHours: 'all').This description was created by
for 91b740c. It will automatically update as commits are pushed.