fix evaluation scores graph

[dinmukhamedm]

Previously all points that were strictly equal to the upper bound of the last bucket would be added to every bucket

---

Important

Fixes SQL query in evaluation_scores.rs to correctly handle points equal to the upper bound of the last bucket in evaluation score buckets.

• Behavior:
  • Fixes SQL query in get_evaluation_score_buckets_based_on_bounds() in evaluation_scores.rs to correctly handle points equal to the upper bound of the last bucket.
  • Adds additional binding for bucket_count to ensure correct bucket assignment.
• Misc:
  • Updates SQL query logic to prevent double counting of values at bucket boundaries.

^{This description was created by for 0d5b8b0. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 0d5b8b0 in 11 seconds

More details

• Looked at 21 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. app-server/src/ch/evaluation_scores.rs:236

• Draft comment:
  Ensure that the bind parameters match the placeholders in the SQL query. The current change adds bucket_count as a bind parameter, which corresponds to the ? in the condition (value = ? AND intervals.interval_num = ?). This is correct, but ensure that all other bind parameters are correctly aligned with their respective placeholders.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The PR description indicates a fix for a bug where points equal to the upper bound of the last bucket were added to every bucket. The change in the SQL query correctly addresses this by adding a condition to check the interval number. However, the bind parameters need to match the query placeholders.

Workflow ID: wflow_gV21ZCCjYWbxCFom

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.