Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bedrock anthropic prices as anthropic #255

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Conversation

dinmukhamedm
Copy link
Member

@dinmukhamedm dinmukhamedm commented Dec 3, 2024

OpenLLMetry sends gen_ai.system as anthropic when calling bedrock anthropic, so duplicate the prices as anthropic as well in the DB


Important

Added 7 new anthropic entries to llm_prices in seed.json, duplicating bedrock-anthropic prices for consistency.

  • Database Changes:
    • Added 7 new entries to llm_prices in seed.json for anthropic provider.
    • Models include claude-3-5-haiku-20241022-v1:0, claude-3-5-sonnet-20240620-v1:0, claude-3-5-sonnet-20241022-v2:0, claude-3-haiku-20240307-v1:0, claude-3-opus-20240229-v1:0, and claude-3-sonnet-20240229-v1:0.
    • Prices are duplicated from bedrock-anthropic entries for consistency.

This description was created by Ellipsis for 6232c97. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 7d5e8cf in 54 seconds

More details
  • Looked at 85 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_RygnwuIZZD9WqaBd


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

"updated_at": "2024-12-03 22:51:39.444574+00",
"provider": "anthropic",
"model": "claude-3-5-haiku-20241022-v1:0",
"input_price_per_million": "1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The input_price_per_million, output_price_per_million, and input_cached_price_per_million fields should be numbers, not strings. This is inconsistent with other entries in the file. Please update these fields to use numeric values.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 6232c97 in 27 seconds

More details
  • Looked at 82 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. frontend/lib/db/seed.json:2389
  • Draft comment:
    Ensure consistency in data types for prices. Use numeric types for input_price_per_million, output_price_per_million, and input_cached_price_per_million across all entries. This issue is present in multiple entries, such as lines 2390, 2400, 2410, 2420, 2430, 2440, and 2450.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_WJTMSrRc3VY6F5qg


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@dinmukhamedm dinmukhamedm merged commit 31d14b1 into dev Dec 3, 2024
1 check passed
@dinmukhamedm dinmukhamedm deleted the update/llm-prices branch December 3, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant