Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fully remove old events and rename table for now #261

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

dinmukhamedm
Copy link
Member

@dinmukhamedm dinmukhamedm commented Dec 4, 2024

Important

Remove old event handling and rename events table to old_events, deleting related API routes and frontend components.

  • Behavior:
    • Remove get_events_for_session endpoint from traces.rs.
    • Rename events table to old_events in events.rs.
    • Remove event creation and retrieval functions from events.rs.
  • Routes:
    • Delete routes/events.rs and remove related services from main.rs.
  • Frontend:
    • Delete event-related API routes in frontend/app/api/projects.
    • Remove event-related pages and components in frontend/app/project and frontend/components/event.

This description was created by Ellipsis for 739571b. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 739571b in 27 seconds

More details
  • Looked at 2091 lines of code in 19 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. app-server/src/db/events.rs:88
  • Draft comment:
    Ensure that all references to the events table are updated to old_events to maintain consistency across the codebase.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. app-server/src/main.rs:402
  • Draft comment:
    Ensure that all dependencies on the removed event routes are also removed or refactored to prevent any runtime errors.
  • Reason this comment was not posted:
    Comment did not seem useful.

Workflow ID: wflow_nUeor61tnCoXiYot


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@dinmukhamedm dinmukhamedm merged commit a8dd35f into dev Dec 4, 2024
1 check passed
@dinmukhamedm dinmukhamedm deleted the remove-old-events branch December 4, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant