Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog #271

Merged
merged 3 commits into from
Dec 6, 2024
Merged

Blog #271

merged 3 commits into from
Dec 6, 2024

Conversation

skull8888888
Copy link
Collaborator

@skull8888888 skull8888888 commented Dec 6, 2024

Important

Update blog layout, add new content for online evaluations, and adjust BlogMeta component layout.

  • Layout and Styling:
    • Update layout in page.tsx to center content and adjust margins.
    • Change text color for paragraphs and links to text-white/85 and text-white respectively.
    • Adjust image width in page.tsx and blog-meta.tsx to md:w-[1000px].
  • Content:
    • Add new blog post 2024-12-06-online-evals.mdx detailing online evaluations feature.
    • Update 2024-12-01-launch-week-1.mdx to include additional launch days and descriptions.
  • Components:
    • Modify BlogMeta component in blog-meta.tsx to adjust layout and image handling.
  • Dependencies:
    • Update posthog-js version in package.json.

This description was created by Ellipsis for cf71d84. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 7507df2 in 19 seconds

More details
  • Looked at 215 lines of code in 4 files
  • Skipped 3 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. frontend/app/blog/[slug]/page.tsx:51
  • Draft comment:
    The level for h1 is set to 0, which is invalid. It should start from 1. Adjust the level accordingly.
  • Reason this comment was not posted:
    Comment was not on a valid diff hunk.

Workflow ID: wflow_zpmnrRoED8biuodM


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on cf71d84 in 8 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 1 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. frontend/package.json:80
  • Draft comment:
    Ensure that the update to posthog-js version ^1.194.4 is compatible with the rest of the codebase and does not introduce breaking changes.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change in the version of posthog-js should be verified for compatibility and potential breaking changes.

Workflow ID: wflow_Hmi0MVMJC3eL14yL


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.


### 1. Span Paths

Span paths uniquely identify where LLM calls happen in your code. They're automatically constructed from the location of the call, making it easy to track specific functions and endpoints.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe a doc link to https://docs.lmnr.ai/tracing/structure#grouping-spans-into-traces

But not necessary, those docs don't specialize on path

{data.image &&
<div className="w-full flex items-center py-4">
<Image src={data.image} alt={data.title} width={1200} height={800} />
<div className="w-full flex rounded overflow-hidden">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while we're at it, do we need border here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no

@skull8888888 skull8888888 merged commit ec063f5 into dev Dec 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants