-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blog #271
Blog #271
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Reviewed everything up to 7507df2 in 19 seconds
More details
- Looked at
215
lines of code in4
files - Skipped
3
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. frontend/app/blog/[slug]/page.tsx:51
- Draft comment:
Thelevel
forh1
is set to 0, which is invalid. It should start from 1. Adjust the level accordingly. - Reason this comment was not posted:
Comment was not on a valid diff hunk.
Workflow ID: wflow_zpmnrRoED8biuodM
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good to me! Incremental review on cf71d84 in 8 seconds
More details
- Looked at
13
lines of code in1
files - Skipped
1
files when reviewing. - Skipped posting
1
drafted comments based on config settings.
1. frontend/package.json:80
- Draft comment:
Ensure that the update toposthog-js
version^1.194.4
is compatible with the rest of the codebase and does not introduce breaking changes. - Reason this comment was not posted:
Confidence changes required:50%
The change in the version ofposthog-js
should be verified for compatibility and potential breaking changes.
Workflow ID: wflow_Hmi0MVMJC3eL14yL
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet
mode, and more.
|
||
### 1. Span Paths | ||
|
||
Span paths uniquely identify where LLM calls happen in your code. They're automatically constructed from the location of the call, making it easy to track specific functions and endpoints. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe a doc link to https://docs.lmnr.ai/tracing/structure#grouping-spans-into-traces
But not necessary, those docs don't specialize on path
{data.image && | ||
<div className="w-full flex items-center py-4"> | ||
<Image src={data.image} alt={data.title} width={1200} height={800} /> | ||
<div className="w-full flex rounded overflow-hidden"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while we're at it, do we need border here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no
Important
Update blog layout, add new content for online evaluations, and adjust
BlogMeta
component layout.page.tsx
to center content and adjust margins.text-white/85
andtext-white
respectively.page.tsx
andblog-meta.tsx
tomd:w-[1000px]
.2024-12-06-online-evals.mdx
detailing online evaluations feature.2024-12-01-launch-week-1.mdx
to include additional launch days and descriptions.BlogMeta
component inblog-meta.tsx
to adjust layout and image handling.posthog-js
version inpackage.json
.This description was created by for cf71d84. It will automatically update as commits are pushed.