increase payload limit for api /v1 to 200MB #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 2e5f424 in 28 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_1d3y1vJgzLRyQBon
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -404,7 +404,7 @@ fn main() -> anyhow::Result<()> { | |||
| .service(api::v1::evaluations::create_evaluation) | |||
| .service(api::v1::metrics::process_metrics) | |||
| .service(api::v1::semantic_search::semantic_search) | |||
| .app_data(PayloadConfig::new(10 * 1024 * 1024)), | |||
| .app_data(PayloadConfig::new(200 * 1024 * 1024)), | |||
There was a problem hiding this comment.
Increasing the payload limit to 200MB can expose the server to potential denial-of-service (DoS) attacks due to large payloads. Consider implementing additional checks or rate limiting to mitigate this risk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some people load large payloads in evals, this is a quick fix
Important
Increase payload limit for
/v1API scope to 200MB inmain.rs./v1API scope from 10MB to 200MB inmain.rs.This description was created by
for 2e5f424. It will automatically update as commits are pushed.