Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix association properties bug and add prompt from ai sdk #291

Merged
merged 2 commits into from
Dec 25, 2024
Merged

Conversation

dinmukhamedm
Copy link
Member

@dinmukhamedm dinmukhamedm commented Dec 25, 2024

Important

Fixes association properties key format and adds handling for AI SDK prompts in spans.rs.

  • Bug Fixes:
    • Corrects key format for accessing attributes in SpanAttributes methods: session_id(), user_id(), trace_type(), and provider_name().
  • New Features:
    • Adds handling for Vercel AI SDK's ai.prompt attribute in Span::from_otel_span() to set span.input.
  • Misc:
    • Updates key format in Span::create_parent_span_in_run_trace() for trace_type attribute.

This description was created by Ellipsis for 9898691. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 9898691 in 15 seconds

More details
  • Looked at 66 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. app-server/src/traces/spans.rs:59
  • Draft comment:
    The change from {ASSOCIATION_PROPERTIES_PREFIX}session_id to {ASSOCIATION_PROPERTIES_PREFIX}.session_id ensures consistency in attribute key formatting. This change is correctly applied across multiple methods.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The change from using a dot in the prefix is consistent across multiple methods, ensuring uniformity in attribute keys.
2. app-server/src/traces/spans.rs:69
  • Draft comment:
    The change from {ASSOCIATION_PROPERTIES_PREFIX}user_id to {ASSOCIATION_PROPERTIES_PREFIX}.user_id ensures consistency in attribute key formatting. This change is correctly applied across multiple methods.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The change from using a dot in the prefix is consistent across multiple methods, ensuring uniformity in attribute keys.
3. app-server/src/traces/spans.rs:79
  • Draft comment:
    The change from {ASSOCIATION_PROPERTIES_PREFIX}trace_type to {ASSOCIATION_PROPERTIES_PREFIX}.trace_type ensures consistency in attribute key formatting. This change is correctly applied across multiple methods.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The change from using a dot in the prefix is consistent across multiple methods, ensuring uniformity in attribute keys.
4. app-server/src/traces/spans.rs:463
  • Draft comment:
    The change from {ASSOCIATION_PROPERTIES_PREFIX}trace_type to {ASSOCIATION_PROPERTIES_PREFIX}.trace_type ensures consistency in attribute key formatting. This change is correctly applied across multiple methods.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The change from using a dot in the prefix is consistent across multiple methods, ensuring uniformity in attribute keys.

Workflow ID: wflow_wCyRa5DikTanW3GT


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@dinmukhamedm dinmukhamedm merged commit 50defb1 into main Dec 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant