Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove endpoints and update readme #304

Merged
merged 2 commits into from
Jan 5, 2025
Merged

remove endpoints and update readme #304

merged 2 commits into from
Jan 5, 2025

Conversation

dinmukhamedm
Copy link
Member

@dinmukhamedm dinmukhamedm commented Jan 5, 2025

Important

Remove endpoint-related files and update README to mark dataset indexing as complete.

  • Endpoints:
    • Removed route.ts files for checks, log-datasets, pipeline-version-graphs, pipeline-versions, and endpoints in frontend/app/api/projects/[projectId]/endpoints/[endpointId]/.
    • Removed deploy-button.tsx, endpoint-select.tsx, and endpoint-version-select.tsx from frontend/components/.
  • Documentation:
    • Updated README.md to mark the dataset indexing and retrieval feature as complete.

This description was created by Ellipsis for ae26057. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to ae26057 in 12 seconds

More details
  • Looked at 702 lines of code in 10 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. README.md:25
  • Draft comment:
    The README update correctly reflects the completion of the feature for indexing datasets and retrieving semantically-similar examples. No issues here.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The README file has been updated to reflect the completion of a feature. This change is consistent with the PR title and description, which mention the removal of endpoints and updating the README. No issues are found in this part of the PR.

Workflow ID: wflow_F5fta2ZBkJ5YZY2S


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@dinmukhamedm dinmukhamedm merged commit e017baa into main Jan 5, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant