Dataset pagination

[devansh-m12]

Description

• Implemented manual pagination for datasets as requested fixes Add manual pagination to the datasets page #233 .
• Took reference from components/traces/traces-table.tsx for implementation.

---

Changes Made

1. Added manual pagination logic to the dataset component.
2. Ensured seamless navigation between pages.

---

Additional Context

• Attached a video demonstrating the working proof of manual pagination.

Screen.Recording.2025-01-06.at.10.06.11.PM.mov

---

Testing

• Verified functionality locally and confirmed pagination works as expected.
• Reviewed edge cases for navigation and data consistency.

@dinmukhamedm please let me know for any changes required.

---

Important

Implements manual pagination in Datasets component with custom data fetching and state management.

• Behavior:
  • Implements manual pagination in Datasets component, replacing SWR with custom fetch logic.
  • Adds getDatasets() function to fetch paginated data based on pageNumber and pageSize.
  • Updates dataset deletion logic to refresh data using getDatasets().
• State Management:
  • Introduces datasets, totalCount, pageNumber, and pageSize state variables.
  • Calculates pageCount based on totalCount and pageSize.
• UI Changes:
  • Updates DataTable to support manual pagination with onPageChange handler.
  • Adjusts URL search parameters for pagination state.

^{This description was created by for 6d1b04e. It will automatically update as commits are pushed.}

[ellipsis-dev]

❌ Changes requested. Reviewed everything up to 6d1b04e in 1 minute and 54 seconds

More details

• Looked at 98 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. frontend/components/datasets/datasets.tsx:33

• Draft comment:
  useSearchParams and usePathname should not be called as functions. They are hooks that return objects, so you should use them directly without calling them.
• Reason this comment was not posted:
  Comment looked like it was already resolved.

2. frontend/components/datasets/datasets.tsx:81

• Draft comment:
  Avoid calling getDatasets twice in handleDeleteDatasets. Consider moving it to a finally block to ensure it's called once after the try-catch block.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable:
  The current implementation only refreshes the dataset list if the deletion was successful (res.ok). This is actually the correct behavior - we don't want to refresh the list if the deletion failed. Moving getDatasets() to a finally block would mean we refresh even on failure, which is wrong. The comment's suggestion would introduce a bug.
  Maybe there's a race condition I'm not seeing? Or maybe refreshing on failure would be helpful to ensure the UI is in sync?
  No, refreshing on failure would be incorrect - if the deletion failed, the datasets still exist in the backend, so there's no need to refresh. The current implementation correctly only refreshes after confirmed deletion.
  The comment should be deleted because its suggestion would make the code worse by refreshing the dataset list even when deletion fails.

Workflow ID: wflow_Ouadd2vje7jUXXLR

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

Consider adding error handling for the fetch call to prevent unhandled promise rejections.

[dinmukhamedm]

LGTM