Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to hide "Loading profile" messages on start #797

Closed
tiymat opened this issue Apr 29, 2024 · 2 comments · Fixed by #794
Closed

Option to hide "Loading profile" messages on start #797

tiymat opened this issue Apr 29, 2024 · 2 comments · Fixed by #794
Labels
deployed to `develop` Feature built. Currently BETA testing in the `develop` branch enhancement New features

Comments

@tiymat
Copy link
Contributor

tiymat commented Apr 29, 2024

Describe the problem:
It would be nice to be able to hide the Loading profile/Loading module messages that occur when the shell starts up. I don't think this would make debugging issues with a module or profile more difficult, as if I put a wrong/gibberish command in e.g. my .murex_profile file, the file and line number of the offending command will still be visible in the stderr.

Possible ways to implement:
Not sure, I actually looked into writing a pull request implementing this as config option in the shell app, with the default set to the existing behaviour of showing the messages.
However, I ran into the issue that the messages are printed before the file is parsed. Setting the config option in .murex_preload would hide the later message about loading .murex_profile, but not the one about loading .murex_preload itself, etc.

It could well be that in practice this is unworkable or not worth the time, but if not I think it would be a nice feature to have.

@tiymat tiymat added the enhancement New features label Apr 29, 2024
@lmorg
Copy link
Owner

lmorg commented Apr 29, 2024

Yeah, this couldn't be a setting in .murex_preload unfortunately for exactly the reason you outlined. But it could be an environmental variable and/or command line flag that is passed to murex upon start up. eg murex --quiet

lmorg added a commit that referenced this issue May 1, 2024
@lmorg lmorg linked a pull request May 1, 2024 that will close this issue
@lmorg
Copy link
Owner

lmorg commented May 2, 2024

Nice work on the PR @tiymat 👍

@lmorg lmorg added the deployed to `develop` Feature built. Currently BETA testing in the `develop` branch label May 29, 2024
@lmorg lmorg mentioned this issue Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed to `develop` Feature built. Currently BETA testing in the `develop` branch enhancement New features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants