Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readline: preview doesn't render if terminal width < 80 #805

Closed
lmorg opened this issue Jun 14, 2024 · 0 comments · Fixed by #794
Closed

readline: preview doesn't render if terminal width < 80 #805

lmorg opened this issue Jun 14, 2024 · 0 comments · Fixed by #794
Labels
bug Unexpected behavior deployed to `develop` Feature built. Currently BETA testing in the `develop` branch

Comments

@lmorg
Copy link
Owner

lmorg commented Jun 14, 2024

Describe the bug:
readline preview doesn't render if terminal width is less than 80 characters. This is a throwback from when the preview was an overlay in the top right-hand corner (rather than full screen) and thus width was multiples of 40, minimum being 80 to support man page rendering (also predating preview parsing in a PTY)

Expected behaviour:
preview should work with narrower terminals. Maybe minimum of 10 characters...?

Platform (please complete the following information):

  • OS, output from uname -a if supported: Linux, macOS
  • Terminal Emulator: Konsole, iTerm
  • Murex version, output from version --no-app-name: latest develop build

Additional context
N/A
@lmorg lmorg added the bug Unexpected behavior label Jun 14, 2024
lmorg added a commit that referenced this issue Jun 14, 2024
@lmorg
#805 readline: allow slimmer terminal widths in preview
545ec79
@lmorg lmorg changed the title readline: preview doesn't render if ternimal width < 80 readline: preview doesn't render if terminal width < 80 Jun 14, 2024
@lmorg lmorg added in progress Issue is currently being worked on (possibly in a feature branch) deployed to `develop` Feature built. Currently BETA testing in the `develop` branch labels Jun 14, 2024
@lmorg lmorg linked a pull request Jun 14, 2024 that will close this issue
v6.1 #794
Merged
lmorg added a commit that referenced this issue Jun 14, 2024
@lmorg
#805 override MaxTabCompleterRows on short terminals
8b9372a
@lmorg lmorg mentioned this issue Jun 19, 2024
Merged
@BrewTestBot BrewTestBot mentioned this issue Jun 27, 2024
Merged
@lmorg lmorg removed the in progress Issue is currently being worked on (possibly in a feature branch) label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Unexpected behavior deployed to `develop` Feature built. Currently BETA testing in the `develop` branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

v6.1 lmorg/murex
1 participant
@lmorg