Skip to content

Fix validation and remove unnecessary assert statements #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 21, 2024
Merged

Fix validation and remove unnecessary assert statements #507

merged 6 commits into from
Jul 21, 2024

Conversation

cpaniaguam
Copy link
Collaborator

This pull request includes several changes to improve validation and remove unnecessary assert statements in the codebase.

The following changes are included:

  • validation for the name parameter in the constructor, bounds, and types for regression formula and regression prior

  • removal of unnecessary assert statements in the code in favor of raising exeptions

@cpaniaguam cpaniaguam linked an issue Jul 19, 2024 that may be closed by this pull request
Raise ValueError instead of assert #503
Closed
@cpaniaguam cpaniaguam self-assigned this Jul 19, 2024
@cpaniaguam cpaniaguam requested a review from digicosmos86 July 19, 2024 19:25
@cpaniaguam cpaniaguam added the enhancement New feature or request label Jul 19, 2024
AlexanderFengler
AlexanderFengler approved these changes Jul 21, 2024
View reviewed changes
Copy link
Collaborator

@AlexanderFengler AlexanderFengler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@cpaniaguam cpaniaguam merged commit 4f0fffa into main Jul 21, 2024
2 checks passed
@digicosmos86 digicosmos86 deleted the 503-raise-valueerror-instead-of-assert branch November 28, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderFengler AlexanderFengler AlexanderFengler approved these changes

@digicosmos86 digicosmos86 Awaiting requested review from digicosmos86

Assignees

@cpaniaguam cpaniaguam

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Raise ValueError instead of assert
2 participants
@cpaniaguam @AlexanderFengler