Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI actions and replace unmaintained actions #141

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

dunxen
Copy link
Collaborator

@dunxen dunxen commented Jul 19, 2024

  • All actions-rs actions are unmaintained, so we'll use dtolnay's rust-toolchain action and just manually run the cargo action commands as well as cargo audit.
  • I've also regenerated release-related workflow with cargo-dist v0.18.0

This should get rid of a bunch of warnings in the actions logs related to node 16 as well, I believe.

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (5535413) to head (8fc2c32).
Report is 2 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #141   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           1       1           
  Lines          97      97           
======================================
  Misses         97      97           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dunxen dunxen requested a review from orbitalturtle July 19, 2024 21:20
Copy link
Collaborator

@orbitalturtle orbitalturtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for keeping these updated. 🙏🏻 So has dtolnay's project become the de facto alternative? I'm just curious if there's a splintering in the community over what to use.

@dunxen
Copy link
Collaborator Author

dunxen commented Jul 20, 2024

So has dtolnay's project become the de facto alternative? I'm just curious if there's a splintering in the community over what to use.

Yeah I couldn't find a fork of the actions-rs org and it seems most are moving to dtolnay's action from PRs linked to this issue: actions-rs/toolchain#216.

If rustup is available on the image we could also just manually install cargo stable.

@orbitalturtle
Copy link
Collaborator

Yeah I couldn't find a fork of the actions-rs org and it seems most are moving to dtolnay's action from PRs linked to this issue: actions-rs/toolchain#216.

Ahh I see, also it looks like it's "used by" 28k projects according to the github repository home page and he kind of won me over a bit with this comment: https://www.reddit.com/r/rust/comments/vyx4oj/comment/ig54zv7/. The main problem people seem to have from scanning the comments is it doesn't support very complex features, which isn't a problem for us, so I'd be down to use it

@orbitalturtle orbitalturtle merged commit c505ca4 into lndk-org:master Jul 23, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants