offers: don't include unadvertised nodes as introduction node candidates #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #154 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 1 1
Lines 105 126 +21
======================================
- Misses 105 126 +21 ☔ View full report in Codecov by Sentry. |
orbitalturtle
force-pushed
the
intro-announced-peers
branch
2 times, most recently
from
dd43ae2 to
0ecc4ea
Compare
kannapoix
reviewed
Aug 28, 2024
dunxen
approved these changes
Aug 28, 2024
| // advertised node with at least one public channel. | ||
| match connector.get_node_info(peer.pub_key, true).await { | ||
| Ok(node) => { | ||
| if node.channels.is_empty() { |
There was a problem hiding this comment.
I've confirmed that the corresponding LND call only gives announced channels here, so looks good 👍
orbitalturtle
force-pushed
the
intro-announced-peers
branch
from
0ecc4ea to
5acb051
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When requesting an invoice from an offer, we need to create a reply path for the offer node to reply to. When creating this path we currently don't check whether the introduction node we selected is advertised (with public channels) or not:
lndk/src/lndk_offers.rs
Line 254 in 259de8b
This PR makes sure we pick an advertised node, which the offer node will actually be able to reach, potentially improving payment reliability.